Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abh1sar wants to merge 5 commits into apache:main
base: main
Choose a base branch
Loading
from shapeblue:vpn-cust-gw

Conversation

@abh1sar
Copy link
Contributor

@abh1sar abh1sar commented Dec 4, 2025
edited by github-actions bot
Loading

Copy link
Contributor Author

abh1sar commented Dec 17, 2025

@blueorangutan docbuild

Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 466)

warning message encouraging users to change it to a more secure
alternative.

- The ``listVpnCustomerGateways`` API response includes two new boolean
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abh1sar - I think the list vpncustomergateways API response fields are a list of strings, not boolean.

  • In the actual API response, the field names are obsoleteparameters and excludedparameters
  • Field type is string, not boolean
  • Fields contain the actual parameter list, e.g., "[sha1, 3des]"

Can we please update this in the docs to match the actual implementation?

(testuser) 🐱 > list vpncustomergateways keyword=test-both
{
 "count": 1,
 "vpncustomergateway": [
 {
 "account": "testuser",
 "cidrlist": "0.0.0.0/0",
 "domain": "TestDomain",
 "domainid": "0fb6c46d-1d16-48b4-b146-9234ec22e63e",
 "domainpath": "ROOT/TestDomain",
 "dpd": false,
 "esplifetime": 3600,
 "esppolicy": "aes256-sha256",
 "excludedparameters": "[3des]",
 "forceencap": false,
 "gateway": "10.1.1.8",
 "hasannotations": false,
 "id": "89bf9794-f457-4cb9-b617-da93f268eb12",
 "ikelifetime": 86400,
 "ikepolicy": "3des-sha1;modp2048",
 "ikeversion": "ikev2",
 "ipsecpsk": "test123",
 "name": "test-both",
 "obsoleteparameters": "[sha1]",
 "splitconnections": false
 }
 ]
}

Copy link

@RosiKyu RosiKyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhisar, I've added some comments, could you please check them?

Copy link
Contributor Author

abh1sar commented Dec 22, 2025

@blueorangutan docbuild

Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 468)

Copy link

@RosiKyu RosiKyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

abh1sar commented Dec 23, 2025

@blueorangutan docbuild

Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 469)

@abh1sar abh1sar marked this pull request as ready for review January 13, 2026 07:35
@abh1sar abh1sar changed the base branch from 4.20 to main January 13, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

+1 more reviewer

@RosiKyu RosiKyu RosiKyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /