-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-33459: [C++][Python] Support step >= 1 in list_slice kernel #48769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@HyukjinKwon
HyukjinKwon
requested review from
AlenkaF,
raulcd and
rok
as code owners
January 7, 2026 22:26
@github-actions
github-actions
bot
added
Component: C++
Component: Python
awaiting review
Awaiting review
awaiting committer review
Awaiting committer review
and removed
awaiting review
Awaiting review
labels
Jan 7, 2026
@HyukjinKwon
HyukjinKwon
force-pushed
the
GH-33459
branch
2 times, most recently
from
January 8, 2026 00:08
be844b7 to
90ae6a2
Compare
@HyukjinKwon
HyukjinKwon
force-pushed
the
GH-33459
branch
from
January 8, 2026 01:12
90ae6a2 to
75fff9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Rationale for this change
Closes ARROW-18281, which has been open since 2022. The
list_slicekernel currently rejectsstart == stop, but should return empty lists instead (following Python slicing semantics).The implementation already handles this case correctly. When ARROW-18282 added step support,
bit_util::CeilDiv(stop - start, step)naturally returns 0 forstart == stop, producing empty lists. The only issue was the validation check (start >= stop) that prevented this from working.What changes are included in this PR?
start >= stoptostart > stopAre these changes tested?
Yes, tests were added.
Are there any user-facing changes?
Yes.
Before:
After: