This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: set display: flex for sidenav by default
#12083
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
@google-cla
google-cla
bot
added
the
cla: no
PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
label
Mar 23, 2021
Author
ersachin3112
commented
Mar 23, 2021
@googlebot I signed it!
@google-cla
google-cla
bot
added
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
and removed
cla: no
PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
labels
Mar 23, 2021
@Splaktar
Splaktar
added
P3: important
Important issues that really should be fixed when possible.
type: bug
labels
Apr 7, 2021
bangarshubham
bangarshubham
approved these changes
Jul 22, 2021
@Splaktar
Splaktar
added
the
needs: manual testing
This issue or PR needs to have some manual testing and verification done
label
Jul 22, 2021
Contributor
Splaktar
commented
Jul 22, 2021
This is likely not something that we can get merged during the LTS. It would have been possible to consider it last July for the 1.2.0 release since this change is likely to break some apps.
For now, it's probably best to just override this style in your app.
@Splaktar
Splaktar
added
- Breaking Change
resolution: too risky
There is too much risk or disruption with this proposal for our limited resources.
labels
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Checklist
Please check your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes #10040
What is the new behavior?
Does this PR introduce a breaking change?
Other information
No