Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix-32253 #32405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teja2 wants to merge 3 commits into angular:main
base: main
Choose a base branch
Loading
from teja2:fix-32253
Open

fix-32253 #32405

teja2 wants to merge 3 commits into angular:main from teja2:fix-32253

Conversation

@teja2
Copy link

@teja2 teja2 commented Nov 25, 2025

No description provided.

@teja2 teja2 requested a review from a team as a code owner November 25, 2025 17:27
@teja2 teja2 requested review from adolgachev and crisbeto and removed request for a team November 25, 2025 17:27
Copy link

google-cla bot commented Nov 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

* `multiTemplateDataRows` or adding/removing row definitions.
*/
private _forceRenderDataRows() {
this._viewRepeater.detach();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this breaks some tests. Also my impression is that detach is only meant to be called once.

Copy link
Author

teja2 commented Nov 26, 2025

@crisbeto updated the PR. Added a clearCache hook to _RecycleViewRepeaterStrategy and switched CdkTable’s forced re-render path to call it so recycled rows are flushed without repeatedly tearing down the entire repeater.

Copy link
Author

teja2 commented Nov 26, 2025

Fixed the tests as well

Copy link
Member

It looks like the tests are still failing. Also CLA isn't signed.

Copy link
Author

teja2 commented Nov 27, 2025

@crisbeto can you please now. locally it is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crisbeto crisbeto crisbeto left review comments

@adolgachev adolgachev Awaiting requested review from adolgachev adolgachev was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /