Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: clarify comparison range colors in date range picker example #31663 #32366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teja2 wants to merge 1 commit into angular:main
base: main
Choose a base branch
Loading
from teja2:fix-31663-datepicker-comparison-colors

Conversation

@teja2
Copy link

@teja2 teja2 commented Nov 17, 2025

No description provided.

@teja2 teja2 requested a review from a team as a code owner November 17, 2025 20:47
@teja2 teja2 requested review from adolgachev and wagnermaciel and removed request for a team November 17, 2025 20:47
Copy link

google-cla bot commented Nov 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@teja2 teja2 changed the title (削除) date range -background color added (削除ここまで) (追記) docs: clarify comparison range colors in date range picker example #31663 (追記ここまで) Nov 17, 2025
Copy link

Panossa commented Nov 17, 2025

I'm not an Angular dev, but it seems to me that using ViewEncapsulation.NONE might break other examples or break because of other examples. Maybe using ng-deep could work as a quick hack to at least not create unwanted connections between examples.

I hope someone with more experience than me can confirm or deny.

Copy link
Author

teja2 commented Nov 23, 2025

@adolgachev / @wagnermaciel any update on this please?

1 similar comment
Copy link
Author

teja2 commented Nov 26, 2025

@adolgachev / @wagnermaciel any update on this please?

Copy link
Contributor

Hi @teja2, sorry for the delay here! I was out sick but I'm back now 💪. I'm sharing the same concern as @Panossa - The use of ViewEncapsulation.NONE will likely break other component examples. Can you attach a screenshot of what you're trying to accomplish with these style changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adolgachev adolgachev Awaiting requested review from adolgachev adolgachev was automatically assigned from angular/components-googlers

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /