Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(cdk/schematics): remove TODO by centralizing stylesheet discovery #32281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alessiopelliccione wants to merge 1 commit into angular:main
base: main
Choose a base branch
Loading
from alessiopelliccione:refactor/cdk-schematics-improve-stylesheet-finding

Conversation

@alessiopelliccione
Copy link

@alessiopelliccione alessiopelliccione commented Nov 8, 2025

This PR refactors the stylesheet discovery logic within the CDK schematics to centralize and simplify how .css and .scss files are located.

It removes a previous TODO by introducing a shared utility that ensures consistent behavior across all schematics relying on global or project-level styles.

Closes #24032

@alessiopelliccione alessiopelliccione requested review from adolgachev and ok7sai and removed request for a team November 8, 2025 16:14
@angular-robot angular-robot bot added the area: cdk/schematics cdk/schematics is *not* a public API label Nov 8, 2025
@adolgachev adolgachev added dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Nov 13, 2025
Copy link

Deployed dev-app for 0234edc to: https://ng-dev-previews-comp--pr-angular-components-32281-dev-q4fpof7p.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link

Deployed docs-preview for 0234edc to: https://ng-dev-previews-comp--pr-angular-components-32281-docs-12rxqgv9.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adolgachev adolgachev Awaiting requested review from adolgachev adolgachev was automatically assigned from angular/components-googlers

@ok7sai ok7sai Awaiting requested review from ok7sai ok7sai was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: cdk/schematics cdk/schematics is *not* a public API dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ng-update: consult workspace configuration for determining global stylesheets

AltStyle によって変換されたページ (->オリジナル) /