-
Notifications
You must be signed in to change notification settings - Fork 865
[4.x] docs(i18n): explicit id support in Angular 4.x #3074
Conversation
googlebot
commented
Jan 4, 2017
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
1 similar comment
googlebot
commented
Jan 4, 2017
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
85bff81 to
77f77c7
Compare
googlebot
commented
Jan 4, 2017
CLAs look good, thanks!
1 similar comment
googlebot
commented
Jan 4, 2017
CLAs look good, thanks!
based on PR #2941
Do NOT merge to master until we know where to put docs for Angular 4.x