This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Angular in .NET Core #2850

Open

rexebin wants to merge 23 commits into angular:master

from rexebin:dotnet-cookbook

Open

Angular in .NET Core #2850

rexebin wants to merge 23 commits into angular:master from rexebin:dotnet-cookbook

Conversation

@rexebin

Copy link

Contributor

@rexebin rexebin commented Nov 21, 2016 •

edited

Loading

Here just so i can gather comments ... DO NOT MERGE

rexebin added 19 commits

November 19, 2016 23:35

@rexebin


 in-progress-cookbook.

fdaac46

@rexebin


 Angular-dotnet-core: WIP

a1fa841

@rexebin


 angular-dotnet-core: draft is done.

194ff72

@rexebin


 minor title adjustment.

eed7699

@rexebin


 move code to _example

ce0af2a

@rexebin


 update cookbook.

01fa33c

@rexebin


 review draft.

b85b2e2

@rexebin


 minor correction

cf3f0c8

@rexebin


 minor corrections

91f187e

@rexebin


 reviews

b150246

@rexebin


 further review.

a6469a7

@rexebin


 minor

db4a840

@rexebin


 Add angular in .net core to navigation menu.

e44c18b

@rexebin


 remove comment in systemjs.config

427f7fc

@rexebin


 minor changes to layout.

@rexebin


 Update angular-in-dotnet-core.jade

29ac24c

@rexebin


 review is done.

7d00448

@rexebin


 minor correction.

80229e8

@rexebin


 minor correction.

3360fb7

@googlebot googlebot added the CLA: yes label

Nov 21, 2016

johnpapa

johnpapa reviewed

Nov 21, 2016

View reviewed changes

Copy link

Contributor

@johnpapa johnpapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i started a review but didnt have time to go through it all. I'll do more later.

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade

:marked

This cookbook describes how to build an Angular app inside the MVC architecture in a .NET Core Web application. It does not explain how Angular or .NET Core works. However it will provide all the code snippets required. Therefore you will be able to follow through this cookbook even if you are currently not familiar with Angular or .NET Core.

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it may be helpful to have a short section here that identifies who the audience is

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

:marked

It is recommended that you follow this cookbook step by step and experience the challenges in the process.

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awkward sentence. Perhaps just remove it

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

It is recommended that you follow this cookbook step by step and experience the challenges in the process.

.NET Core supports cross platforms. You can develop .NET Core applications on Windows, macOS or Linux. This cookbook will use Visual Studio 2015 on Windows.

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest ...

.NET Core is a cross platform solution.

Saying the cookbook uses Windows makes me wonder what will be different on OSX on a Mac. I think it would be good to discuss both in the cookbook, otherwise we cut out a growing audience.

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

:marked

## Prerequisite

If you do not have them in your system, download and install the following items:

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify ...

begin by downloading and installing the following requirements:

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

If you do not have them in your system, download and install the following items:

1. [Visual studio 2015 Update 3](https://go.microsoft.com/fwlink/?LinkId=691129)

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Visual Studio ...

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

1. [Visual studio 2015 Update 3](https://go.microsoft.com/fwlink/?LinkId=691129)

1. [.NET Core Tools for Visual Studio 2015](https://go.microsoft.com/fwlink/?LinkId=691978)

1. [.Net Core SDK](https://go.microsoft.com/fwlink/?LinkID=835014)

1. [Typescript 2 for Visual Studio 2015](http://download.microsoft.com/download/6/D/8/6D8381B0-03C1-4BD2-AE65-30FF0A4C62DA/TS2.0.3-TS-release20-nightly-20160921.1/TypeScript_Dev14Full.exe)

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be TypeScript ...

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this link likely to change? is there a safer one?

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

+makeExample('angular-in-dotnet-core/ts/_layout.html', null, 'Views/shared/_layout.cshtml')(format='.')

:marked

Now, build and run the application, you will find that .NET Core MVC application works but the Angular app does not. Open the the developer's tool in the browser, go to the console tab, you will find that the browser is complaining that it cannot find any of the scripts we inserted to `Views/Shared/_layout.cshtml` above.

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compound sentence. Try breaking it up.

Now build and run the application. The .NET Core MVC application works but the Angular app appears not to work! Let's find out why. Open the developer tools in the browser ...

public/docs/ts/latest/cookbook/angular-in-dotnet-core.jade Outdated

#### 404 Errors

These 404 errors indicate that the browser could not find files in `app` and `node_modules` folders. But we have an `app` folder and a `node_modules` folder in the root directory, why the browser can not find it?

Copy link

Contributor

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have app and node_modules folders, but why can't the browser find them?

rexebin added 4 commits

November 22, 2016 10:37

@rexebin


 Edit to reflect John’s comments.

37d3e9f

@rexebin


 Update code snippets for gulp-tslint.

40c3c2d

@rexebin


 Add instructions for .NET Core CLI audiences.

b734514

@rexebin


 Rename example folder with cb prefix.

b95f5d7

Use shell stylings for terminal commands.

@Foxandxss Foxandxss mentioned this pull request

Jan 11, 2017

Update Visual Studio 2015 QuickStart docs to reflect ASP.NET Core #1752

Closed

@juleskremer juleskremer mentioned this pull request

Feb 2, 2017

asp.net core with angular CLI angular/angular-cli#3578

Closed

Labels

CLA: yes

3 participants

@rexebin @johnpapa @googlebot

Angular in .NET Core #2850

Are you sure you want to change the base?

Angular in .NET Core #2850

Uh oh!

Conversation

@rexebin rexebin commented Nov 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@johnpapa johnpapa left a comment

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

@johnpapa johnpapa Nov 21, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@rexebin rexebin commented Nov 21, 2016 •

edited

Loading