-
Notifications
You must be signed in to change notification settings - Fork 865
style-guide(add-a11y): Add accessibility quick wins #1854
Conversation
298fffa to
51a166a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not putting messages between avoid and do (correct me if I am wrong). We could put that as a Consider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we do. Let's hold on this and see if we can do better.
36b8027 to
8043eee
Compare
8043eee to
062c4b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is totally a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's completely fixed.
Foxandxss
commented
Jul 18, 2016
062c4b9 to
4c0cecc
Compare
AlmeroSteyn
commented
Jul 19, 2016
@Foxandxss: There is one flow issue now, because of number 10 being reserved for the router styles. Accessibility now shows as 10 on the menu above and then you end up in section 11. Will fix itself when the router styles are added.
Adding accessibility recommendations to style guide.
These are all quick accessibility wins making use of HTML and CSS alone and requiring no use of ARIA.