-
Notifications
You must be signed in to change notification settings - Fork 865
docs(cb-a11y): add accessibility (a11y) cookbook #1625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noting this here but it's more of a general question - are the code backticks appropriate for calling out technical terms or should some of these really be ems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These do provide a particular emphasis highlight that is used a lot inside the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but typically the code backticks are for actual snippets of code or commands - variable names, hex values, CLI commands, that sort of thing. Whereas technical terms get the em treatment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. However that is more an A2 doc wide discussion so will align this one to the styles of the other docs for now.
08975c4 to
d910c90
Compare
99d1ced to
8b74462
Compare
8b74462 to
bd4d24e
Compare
f484de2 to
603a407
Compare
603a407 to
073be1f
Compare
chalin
commented
Oct 26, 2016
@AlmeroSteyn - e2e tests are failing because the ts compiler is reporting errors. Can you investigate and fix the issues?
chalin
commented
Oct 26, 2016
All: @AlmeroSteyn isn't currently available. As agreed discussed with @wardbell via slack: @Foxandxss or @filipesilva could you look into upgrading the code from use of ng beta/rc to 2.1.x?
googlebot
commented
Oct 26, 2016
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
997a1ee to
bb94ec4
Compare
939abee to
b733a57
Compare
googlebot
commented
Dec 8, 2016
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
1 similar comment
googlebot
commented
Dec 8, 2016
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
niceredfrog
commented
Dec 14, 2016
I authored the most recent commit. I'm replying to confirm.
marcysutton
commented
Apr 7, 2017
What do we need to do to get this up to date and merged?
READY FOR REVIEW
Current and up to date PR for the a11y cookbook.
Also contains copy-edits from @naomiblack from #1181 .
Both #1049 and #1181 are now outdated in terms of content and should be closed, but conserved for comments therein.