-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/ssr): handle platform destruction during rendering #32263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arturovt
arturovt
force-pushed
the
fix/angular_ssr_self_destroy
branch
2 times, most recently
from
January 12, 2026 17:53
366b0fc to
88127de
Compare
alan-agius4
alan-agius4
approved these changes
Jan 13, 2026
@alan-agius4
alan-agius4
added
target: patch
This PR is targeted for the next patch release
action: merge
The PR is ready for merge by the caretaker
labels
Jan 13, 2026
Fixes crash when platform/app destroys itself during the bootstrapping and stabilization phase. Previously, the code would call `applicationRef.injector` without checking if the platform was destroyed, resulting in: "Error: Injector has already been destroyed" This can occur when: - Component constructor calls `inject(PlatformRef).destroy()` - AbortSignal triggers during request handling - APP_INITIALIZER rejects and causes cleanup - Custom guard/resolver logic destroys the platform Solution: Check `applicationRef.destroyed` after `whenStable()` and return error state instead of accessing destroyed injector. Test: Added test case that destroys app in component constructor to verify graceful handling of this edge case.
@alan-agius4
alan-agius4
force-pushed
the
fix/angular_ssr_self_destroy
branch
from
January 13, 2026 08:10
88127de to
02575d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash when platform/app destroys itself during the bootstrapping and stabilization phase. Previously, the code would call
applicationRef.injectorwithout checking if the platform was destroyed, resulting in: "Error: Injector has already been destroyed"This can occur when:
inject(PlatformRef).destroy()Solution: Check
applicationRef.destroyedafterwhenStable()and return error state instead of accessing destroyed injector.Test: Added test case that destroys app in component constructor to verify graceful handling of this edge case.