-
Notifications
You must be signed in to change notification settings - Fork 261
Add ability to share image with Androidify #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mlykotom, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the ability for the Androidify application to seamlessly integrate with Android's system-wide image sharing functionality. It allows users to share images from any compatible application directly into Androidify, where the image is then automatically prepared for editing or creation within the app's workflow.
Highlights
- Image Sharing Capability: The application can now receive shared images from other Android applications through the standard Android sharing mechanism.
- Automated Navigation for Shared Images: When an image is shared to Androidify, the application will automatically launch and navigate directly to the image creation screen, pre-loading the shared image for immediate use.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds the ability to share an image to the app. The implementation has a critical issue in MainNavigation.kt with a conditional remember call, which violates the rules of Compose. Additionally, the handling of the share intent in MainActivity.kt is not robust; it doesn't handle cases where the app is already running (onNewIntent) and doesn't treat the share as a one-time event, which can lead to unexpected behavior on configuration changes. I've provided suggestions to fix these issues by using a LaunchedEffect for one-shot event handling and correctly implementing the Activity lifecycle for intents.
Screen_recording_20250904_123730.mp4