-
-
Notifications
You must be signed in to change notification settings - Fork 49
refactor(event-client): simplify onAllPluginEvents implementation
#315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce5baa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@nperez0111
nperez0111
force-pushed
the
simplify-plugin-events
branch
from
January 13, 2026 11:57
5401a62 to
1cd2e9f
Compare
@nperez0111
nperez0111
changed the title
(削除) refactor: simplify
(追記) refactor(event-client): simplify Jan 13, 2026
onAllPluginEvents implementation (削除ここまで)onAllPluginEvents implementation (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This simplifies the
onAllPluginEventsimplementation, to just re-use theonAllimplementation, since they are essentially duplicates, but theonAllPluginEventsimplementation has an early exit when events are not from this plugin✅ Checklist
pnpm test:pr.🚀 Release Impact