-
Notifications
You must be signed in to change notification settings - Fork 9
Mucha dev fail on any block #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...lations Introduces a new --strict-blocking flag that causes builds to fail on ANY security policy violations with blocking severity, not just new ones. This enables enforcement of a zero-tolerance policy on security issues. Key features: - Works in diff mode only (logs warning in API mode) - Only fails on error-level alerts (not warnings) - --disable-blocking takes precedence when both flags are set - Enhanced console output distinguishes NEW vs EXISTING violations - Comprehensive test coverage for all scenarios Implementation details: - Added unchanged_alerts and removed_alerts fields to Diff class - Created get_unchanged_alerts() method to extract alerts from unchanged packages - Updated report_pass() to check both new and unchanged alerts when enabled - Added validation warnings for conflicting flags and API mode limitations Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added comprehensive documentation for the new --strict-blocking feature: - Added flag to Advanced Configuration parameters table - Created dedicated "Strict Blocking Mode" section with: - Behavior comparison (standard vs strict) - Usage examples for different CI/CD platforms - Output examples showing NEW vs EXISTING violations - Common use cases and implementation strategies - Important notes about limitations and flag priority - Flag combination examples - Migration strategy guidance - Links to GitLab CI example files The documentation clearly explains: - Zero-tolerance security policy enforcement - Diff mode requirement - Error-level filtering (not warnings) - --disable-blocking precedence - First scan behavior Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Bumped version from 2.2.63 to 2.3.1 following semantic versioning (minor version bump for new feature). This version number avoids conflict with the mucha-dev-gitlab-security-output branch which uses 2.3.0 for the GitLab Security Dashboard feature. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@jonathanStrange0
jonathanStrange0
requested a review
from a team
as a code owner
January 15, 2026 17:15
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.66.dev1
Docker image: socketdev/cli:pr-149
dacoburn
dacoburn
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--strict-blockingflag to fail on any existing security violationsIntroduces a new
--strict-blockingflag that causes builds to fail when ANY security policy violations with blocking severity exist, not just new ones introduced in the current changes. This enables organizations to enforce zero-tolerance security policies across their entire codebase.Key Features:
--disable-blockingtakes precedence when both flags are setUsage: