-
-
Notifications
You must be signed in to change notification settings - Fork 891
Remove Nullable Disable from ICC Code #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the nullable disable from the icc Code (And one Tiff). Most parts could be solved relative easily. There are also some parts were the bang operator had to be used.
@stefannikolei
stefannikolei
force-pushed
the
sn/nullable_icc
branch
from
November 21, 2025 22:48
3be0fde to
30a2dfa
Compare
src/ImageSharp/ColorProfiles/Icc/Calculators/CurveCalculator.cs
Outdated
Show resolved
Hide resolved
@stefannikolei
stefannikolei
force-pushed
the
sn/nullable_icc
branch
2 times, most recently
from
November 22, 2025 09:04
2ff7dba to
e013c4e
Compare
Removed not needed nullability Refactored CurveCalculator.Calculate to not need the bang operator
@stefannikolei
stefannikolei
force-pushed
the
sn/nullable_icc
branch
from
November 22, 2025 09:20
e013c4e to
b4cfa7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the nullable disable from the icc Code (And one Tiff). Most parts could be solved relative easily. There are also some parts were the bang operator had to be used.
Prerequisites