Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

apns - handling error from previous batch #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denisborovnev wants to merge 3 commits into Redth:master
base: master
Choose a base branch
Loading
from LogicSoftware:apns_batch_error_handling_fix

Conversation

@denisborovnev
Copy link

@denisborovnev denisborovnev commented Nov 14, 2016
edited
Loading

Sometimes 750ms is not enough to get response from apns when there is an error in batch

In this case all messages in batch marked as sent and connection is reused for new batches.

During sending next batch error is read, but there is no failed notification in current batch and reader does nothing

As a result notifications from this batch are not marked as sent or failed. Also next batches won't be sent because "error" connection is not closed and ApnsConnection instance continues to use it.


To fix this problem:

  • socketCanWrite -> return false if there are available bytes to read in current socket, because it's error from previous batch and new notifications wroten to this connection won't be sent
  • if reader can't find index of failed notification -> push notifications again to queue and close connection
  • added ResponseWaitTimeout into configuration to make it's possible to increase timeout for waiting response from apns (if 750ms is not enough too often)

PS: there is already setting called MillisecondsToWaitBeforeMessageDeclaredSuccess, not sure if it might be used instead of new one ResponseWaitTimeout

when response wasn't read for previous batch (due to
not enough timeout) and for current batch we read error
from previous batch. As a result we can't find failed notification
in current batch
Copy link
Owner

Redth commented Dec 1, 2016

@denisborovnev Is this working well for you in production?

I do think we should use the existing MillisecondsToWaitBeforeDeclaredSuccess as the value. If you can update your PR I'm happy to merge this.

Thanks :)

Copy link
Author

Hi @Redth !
Thanks for review!

I do think we should use the existing MillisecondsToWaitBeforeDeclaredSuccess as the value.

done

Is this working well for you in production?

We haven't released yet, so can't give answer right now :) But we have already tested and haven't faced problem when server stops send any notification for some period of time.

Copy link

Hi @Redth. We have that fix in production, working well, no issues yet. Could you please merge it?

oguzsezer, yurikburko, and Olegasv reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /