Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Handling Empty Enums and Duplicate Enum Entries onLoad #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Corbin wants to merge 1 commit into ReClassNET:master
base: master
Choose a base branch
Loading
from Corbin:ParsingEnumsFix-prevent-crash-on-empty-values-or-duplicates

Conversation

@Corbin
Copy link

@Corbin Corbin commented May 10, 2024

the original code attempted to add every parsed enum to the project without checking if it contained any values. It also did have handling for the possibility of duplicate enum item names within the same enum on load which could also cause crashes.

Duplicates:

Adding a duplicate key to a Dictionary throws an argumentexception, leading to a crash. The code change checks for the existence of a key before adding it. If a duplicate key is found, the value is updated.

Empty Enums

Before adding an enum to the project, the code change checks if the values dictionary associated with the enum is empty. If it is, the enum is not added to the project. This prevents the creation of empty EnumDescription objects, which would lead to errors.

...ues)
the original code attempted to add every parsed enum to the project without checking if it contained any values. It also did have handling for the possibility of duplicate enum item names within the same enum which could also cause crashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sharmaniraj009 sharmaniraj009 sharmaniraj009 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /