Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature/shabbatime #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elor555 wants to merge 44 commits into PythonFreeCourse:develop
base: develop
Choose a base branch
Loading
from elor555:feature/shabbatime

Conversation

@elor555
Copy link

@elor555 elor555 commented Feb 23, 2021
edited
Loading

Create a new feature
In my feature, the shabbat time by the user location of the week are displayed every Saturday (on the dayview page).

i also made location class.
Needs further treatment:

  • style
  • place the location in the right place

@elor555 elor555 changed the base branch from main to develop February 23, 2021 23:56
elor555 added 23 commits February 24, 2021 15:58
# Conflicts:
#	app/routers/dayview.py
#	app/static/dayview.css
#	tests/test_dayview.py
#	tests/test_weekview.py
# Conflicts:
#	app/database/models.py
#	app/routers/dayview.py
#	app/static/dayview.css
Copy link

codecov-io commented Feb 27, 2021
edited
Loading

Codecov Report

Merging #333 (3e96f7d) into develop (5c2136b) will decrease coverage by 0.11%.
The diff coverage is 88.23%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
- Coverage 94.43% 94.31% -0.12% 
===========================================
 Files 91 90 -1 
 Lines 4257 4169 -88 
===========================================
- Hits 4020 3932 -88 
 Misses 237 237 
Impacted Files Coverage Δ
app/routers/dayview.py 97.82% <77.77%> (-1.42%) ⬇️
app/internal/locations.py 78.94% <78.94%> (ø)
app/database/models.py 97.37% <100.00%> (-0.10%) ⬇️
app/internal/json_data_loader.py 100.00% <100.00%> (ø)
app/internal/shabbat.py 100.00% <100.00%> (ø)
app/internal/event.py 95.71% <0.00%> (-0.92%) ⬇️
app/main.py 95.83% <0.00%> (-0.17%) ⬇️
app/dependencies.py 87.50% <0.00%> (ø)
app/routers/export.py 82.35% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2136b...bf56e9b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Gonzom Gonzom Gonzom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /