Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Feature/menstrual predictor #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Liad-n wants to merge 26 commits into PythonFreeCourse:develop
base: develop
Choose a base branch
Loading
from Liad-n:feature/menstrual-predictor

Conversation

@Liad-n
Copy link
Contributor

@Liad-n Liad-n commented Feb 16, 2021

Still some issues with getting period days from db in tests

Copy link
Contributor

@PureDreamer PureDreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work it seems you really thought it through.

Liad-n reacted with thumbs up emoji
Copy link

codecov-io commented Feb 21, 2021 •
edited
Loading

Codecov Report

Merging #314 (f00b080) into develop (8d83f8b) will decrease coverage by 1.27%.
The diff coverage is 42.98%.

Impacted file tree graph 

@@ Coverage Diff @@
## develop #314 +/- ##
===========================================
- Coverage 94.39% 93.11% -1.28% 
===========================================
 Files 89 87 -2 
 Lines 4156 4111 -45 
===========================================
- Hits 3923 3828 -95 
- Misses 233 283 +50
Impacted Files Coverage Δ
app/main.py 95.23% <ø> (-0.60%) ⬇️
app/internal/menstrual_predictor_utils.py 35.38% <35.38%> (ø)
app/routers/menstrual_predictor.py 47.72% <47.72%> (ø)
app/database/models.py 97.23% <100.00%> (-0.14%) ⬇️
app/internal/event.py 95.71% <0.00%> (-0.92%) ⬇️
app/routers/google_connect.py 100.00% <0.00%> (ø)
app/internal/features.py
app/resources/countries.py
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d83f8b...7375a5d. Read the comment docs.

@Liad-n Liad-n requested a review from yammesicka March 30, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yammesicka yammesicka yammesicka requested changes

+2 more reviewers

@ivarshav ivarshav ivarshav left review comments

@PureDreamer PureDreamer PureDreamer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /