-
Notifications
You must be signed in to change notification settings - Fork 52
Feature/cursor #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cursor #307
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #307 +/- ## =========================================== + Coverage 94.39% 94.65% +0.25% =========================================== Files 89 87 -2 Lines 4156 4038 -118 =========================================== - Hits 3923 3822 -101 + Misses 233 216 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need a route for every setting option. This should probably be routers.setting.py and the calls should be:
- @router.get("/settings/cursor")
- @router.post("/settings/cursor")
- @router.get("/{user_id}/cursor")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean that there shouldn't be a [setting_type].py file for each setting type?
So if I have Audio Settings and Cursor Settings, both of them should be in routers.setting.py, but the @router functions should stay the same, only in this new file instead of the old one?
Thanks for your feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Please have a look at my insights :)
...into feature/cursor
...his ticket as well :)
...into feature/cursor
No description provided.