WIP SpeedyMeetings2 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

omrizhaki wants to merge 8 commits into PythonFreeCourse:develop

from omrizhaki:feature/speedymeeting

Open

WIP SpeedyMeetings2 #157

omrizhaki wants to merge 8 commits into PythonFreeCourse:develop from omrizhaki:feature/speedymeeting

Conversation

@omrizhaki

Copy link

@omrizhaki omrizhaki commented Jan 30, 2021

No description provided.

omrizhaki added 3 commits

January 30, 2021 02:56

@omrizhaki


 fix: work with database

3ae432a

@omrizhaki


 fix: flake8

f7f556c

@omrizhaki


 fix: newfile

ca896f4

@omrizhaki omrizhaki changed the base branch from main to develop

January 30, 2021 01:39

omrizhaki added 5 commits

January 30, 2021 03:41

@omrizhaki


 fix: flake8

6380fe3

@omrizhaki


 fix: again

a4fd927

@omrizhaki


 fix: again2

8fe713d

@omrizhaki


 fix: again3

2d04e8e

@omrizhaki


 fix: again4

519f5f9

sagizaidor

sagizaidor reviewed

Jan 30, 2021

View reviewed changes

app/database/models.py

speedy_meetings_enabled = Column(Boolean, default=False)

def has_speedy_meetings_enabled(self) -> bool:

Copy link

Contributor

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

מה המטרה שך הפנציה הזאת? למה לקרוא לה ולא פשוט לא user.speedy_meetings_enabled?

app/database/models.py

participants = relationship("UserEvent", back_populates="events")

def get_event_duration(self):

Copy link

Contributor

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

זה דבר נהוג להכניס פונקציות לModels ולא להוציא את זה לקבצים בinternal?
בדקת את זה לפני?

שואל באמת כי זה פעם ראשונה שאני רואה

@yammesicka

Copy link

Member

yammesicka commented Jan 31, 2021

This is a good start :) Keep going

Labels

None yet

3 participants

@omrizhaki @yammesicka @sagizaidor

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP SpeedyMeetings2 #157

Are you sure you want to change the base?

WIP SpeedyMeetings2 #157

Uh oh!

Conversation

@omrizhaki omrizhaki commented Jan 30, 2021

Uh oh!

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

yammesicka commented Jan 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants