-
Notifications
You must be signed in to change notification settings - Fork 504
Fix: minTextAdapt ignored by default fontSizeResolver (Added FontSizeResolvers.auto) #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I discovered that the
minTextAdaptproperty inScreenUtilInitis ignored in the library's current version.This happens because
ScreenUtilInitinitializes with a defaultfontSizeResolverofFontSizeResolvers.width:Because
setSpprioritizes the resolver if it is not null, the logic delegates tosetWidth. This completely bypasses the internalscaleTextgetter where theminTextAdaptlogic is being used. Because of this, text always scales based on width, even when the user explicitly setsminTextAdapt: true.Solution
I have introduced a new resolver method and updated the default behavior:
Added
FontSizeResolvers.auto: This new static method calculates font size usinginstance.scaleText. This ensures that theminTextAdaptlogic (which chooses the minimum between width and height scaling) is respected.Updated Default in
ScreenUtilInit: Changed the defaultfontSizeResolverfrom.widthto.auto.Technical Note
In
FontSizeResolvers.auto, I am performing the math directly (fontSize * instance.scaleText) rather than callinginstance.setSp(fontSize). This is intentional to prevent an infinite recursion loop, assetSpinternally calls the resolver.Impact
minTextAdapt: false(Default): No change in behavior.scaleTextfalls back toscaleWidth, so it matches the previous.widthbehavior.minTextAdapt: true: The feature will now work as intended, preventing text from becoming excessively large on wide screens (like tablets or web).Checklist
minTextAdapt: true(verified text scales using the smaller factor).minTextAdapt: false(verified text scales using width).