Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improvement: Create new message handler for inbound/outbound messages to support RabbitMQ/others #88 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igwtech wants to merge 6 commits into OpenAS2:master
base: master
Choose a base branch
Loading
from igwtech:Plugin-MQ

Conversation

@igwtech
Copy link
Member

@igwtech igwtech commented Nov 15, 2019

This plugin allows OpenAS2 to interconnect with a Message Queue Broker (i.e RabbitMQ) for message exchange and message tracking events.

Comment on lines +30 to +31
public abstract class MessageBuilderModule extends BaseReceiverModule {

Copy link
Contributor

@uhurusurfa uhurusurfa Nov 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you re-implementing the MessageBuilderModule?
If there is something that you need in the existing one then lets talk about enhancing it rather than duplicating all the code.

Copy link
Member Author

igwtech commented Nov 16, 2019 via email

The original uses the filename to get the partnership info and other metadata. MQ messages have the headers for that purpose. That's was basically the difference. J
...
On Sat, Nov 16, 2019, 10:14 AM Christopher Broderick < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Plugins-MQ/src/main/java/com/greicodex/openas2/plugins/mq/MessageBuilderModule.java <#175 (comment)>: > +public abstract class MessageBuilderModule extends BaseReceiverModule { + Why are you re-implementing the MessageBuilderModule? If there is something that you need in the existing one then lets talk about enhancing it rather than duplicating all the code. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#175?email_source=notifications&email_token=AA2QND7R75EMOPMH5CNFZ2TQT755FA5CNFSM4JN7TLL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLZ6AEY#pullrequestreview-317972499>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2QND2GTWA73IYPWML634DQT755FANCNFSM4JN7TLLQ> .

Copy link
Contributor

Ok - lets make the retrieval of that info into a method in MessageBuilderModule then it can be overridden by modules that need something diffferenmt if necessary or simply pass additional parameters in the AS2Message context object to.
Break MessageBuilder down into smaller methods that can be overridden wherever necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhurusurfa uhurusurfa uhurusurfa left review comments

@VboxNick VboxNick Awaiting requested review from VboxNick

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /