-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix: angular tsconfig wrong @demo/shared path #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NathanWalker
commented
Mar 23, 2022
Thanks @agonper there's one other adjustment the tools need with latest updates to ensure the angular app's tsconfig is correct, it should instead annotate along with each added package like this for example:
{
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"paths": {
"~/*": ["src/*"],
"@demo/shared": ["tools/demo/index.ts"],
"@nativescript/*": ["packages/*"]
}
},
"files": ["./references.d.ts", "./src/main.ts", "./src/polyfills.ts"],
"include": ["../../packages/**/references.d.ts", "../../**/*.android.ts", "../../**/*.ios.ts"]
}
That would allow natural livesync changes with Angular demo.
I'll add this adjustment in the tools this week.
agonper
commented
Mar 23, 2022
You're welcome @NathanWalker. I'm happy to help 🙂 .
That would allow natural livesync changes with Angular demo.
I noticed that too. Now with Ivy it should no longer be necessary to pre-build Angular plugins for live sync, right? That would be an enormous DX boost!
Looking forward seeing that adjustment! Thanks for making NativeScript better every day 😄
NathanWalker
commented
Mar 23, 2022
Correct! Yes that should allow the angular demo to work/livesync like the vanilla demo. Thanks for the kind words 🤗
jnorkus
commented
Apr 20, 2022
Any progress on this issue? I have tried implementing the tsconfig changes but there are still errors resolving modules.
18aaf1b to
5f2d9e0
Compare
Error description
Angular demo build cannot find files under
@demo/sharedscopeSteps to reproduce
image