Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: ability to embed into platform host projects #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmutafov wants to merge 6 commits into NativeScript:main
base: main
Choose a base branch
Loading
from vmutafov:embed

Conversation

@vmutafov
Copy link
Contributor

@vmutafov vmutafov commented Jan 2, 2024

No description provided.

shiv19 reacted with heart emoji
@edusperoni edusperoni changed the base branch from embed to main April 2, 2024 16:17
Copy link
Collaborator

@edusperoni edusperoni Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted

Copy link
Collaborator

@edusperoni edusperoni Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert to keep history clean

Comment on lines +182 to +207
implementation "com.google.android.material:material:$androidXMaterialVersion"
implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion"
implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3'
implementation 'androidx.navigation:navigation-ui-ktx:2.5.3'
Copy link
Collaborator

@edusperoni edusperoni Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these needed? It'd mean all apps now depend on material, androidx navigation and appcompat

Copy link
Collaborator

@edusperoni edusperoni Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptActivity.java isn't currently committed into main)

Copy link
Collaborator

@edusperoni edusperoni Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptApplication.java isn't currently committed into main)

@NathanWalker NathanWalker changed the title (削除) feat: add android embedding and merge main (削除ここまで) (追記) feat: ability to embed into platform host projects (追記ここまで) Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edusperoni edusperoni edusperoni left review comments

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /