Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Skia renderer #6574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bjornharrtell wants to merge 15 commits into MapServer:main
base: main
Choose a base branch
Loading
from bjornharrtell:skia
Draft

Skia renderer #6574

bjornharrtell wants to merge 15 commits into MapServer:main from bjornharrtell:skia

Conversation

@bjornharrtell
Copy link
Contributor

@bjornharrtell bjornharrtell commented Jul 13, 2022
edited
Loading

Rationale:

  • Likely (much?) better performance
  • Well supported

Notes:

  • Requires C++ 17 as minimum
  • Currently working against local Skia compiled with bin/gn gen out/Static --args='is_official_build=true cc="clang" cxx="clang++" skia_pdf_subset_harfbuzz=false skia_use_libwebp_decode=false skia_use_libwebp_encode=false skia_use_gl=false' is_debug=false

Copy link
Member

sdlime commented Jul 14, 2022

Well this is an interesting addition. Are there advantages over AGG?

Copy link
Contributor Author

@sdlime I have reason to believe Skia can significantly outperform AGG.

Copy link
Contributor Author

bjornharrtell commented Jul 14, 2022
edited
Loading

When I began on this I didn't know if it would be achievable without too much effort.. but it is now capable of producing:

ttt

So I'm motivated to continue. :)

sdlime reacted with laugh emoji

Copy link
Contributor Author

bjornharrtell commented Jul 14, 2022
edited
Loading

Did some early benchmarking on 3+ million polygon squares. AGG is a lot faster on that case... somewhere 50% - 80% faster. I believe I've compiled Skia with the optimal settings so currently I can't explain this other than that Skia isn't as fast as I had assumed/thought.

Copy link
Member

sdlime commented Jul 14, 2022

Did some early benchmarking on 3+ million polygon squares. AGG is a lot faster on that case... somewhere 50% - 80% faster. I believe I've compiled Skia with the optimal settings so currently I can't explain this other than that Skia isn't as fast as I had assumed/thought.

Still seems like an interesting option as it is maintained and under active development.

Copy link
Member

jmckenna commented Aug 2, 2022

@bjornharrtell I'll do some Windows testing on this this week. I agree with Steve here, the benefits of using a library that is so well maintained can outweigh other limitations.

Copy link

@pelord , could you clarify what you want to say?

@jmckenna jmckenna removed this from the 8.2.0 Release milestone May 6, 2024
Copy link
Member

jmckenna commented May 6, 2024

removing the 8.2.0 milestone label due to recent discussion.

Copy link
Member

@bjornharrtell just letting you know that the next release plan is coming together, for 8.4.0, in case you have time available before the release to tackle this again. See here for the release plan dates.

(judging by the earlier responses you got about this, I'd say that you have something very interesting, potentially, to others ;)

Copy link

Did some early benchmarking on 3+ million polygon squares. AGG is a lot faster on that case... somewhere 50% - 80% faster. I believe I've compiled Skia with the optimal settings so currently I can't explain this other than that Skia isn't as fast as I had assumed/thought.

Just to add my 0ドル.02. I’ve tried something similar with blend2d graphics library, and I get similar results to you with skia: it’s slower than agg despite all benchmarks saying it’ll be faster.

Consider that most benchmarks are run in programs where the context only has to be setup once as part of a continuously running program, generating several frames as part of some animation.

My theory is that for fast draws of e.g. simple polygons, the overhead of setup of the graphics library context makes the overall render slower than agg. and because CGI that affects all renders. Don’t know if that matches up with what you’ve seen?

Copy link
Contributor Author

@oshawa-connection yeah it could be that the architecture of skia that allows för gpu accel is a disadvantage. That said, I believe they have optimized the software pipeline to great lengths regardless. But I've not dived deep enough to know anything really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /