This repository was archived by the owner on Feb 2, 2024. It is now read-only.

VTune integration #814

Open

1e-to wants to merge 4 commits into IntelPython:master

from 1e-to:vtune_i

Open

VTune integration #814

1e-to wants to merge 4 commits into IntelPython:master from 1e-to:vtune_i

Conversation

@1e-to

Copy link

Contributor

@1e-to 1e-to commented Apr 21, 2020

No description provided.


 VTune integration

384badc

@1e-to 1e-to requested review from AlexanderKalistratov and PokhodenkoSA

April 21, 2020 16:13

@Hardcode84

Copy link

Contributor

Hardcode84 commented Apr 21, 2020

Native part is not included?

AlexanderKalistratov

AlexanderKalistratov reviewed

Apr 21, 2020

View reviewed changes

vtune_integration.py Outdated

ll.add_symbol('__itt_task_begin_new', itt.__itt_task_begin)

ll.add_symbol('__itt_task_end_new', itt.__itt_task_end)

def vtune_profiling_boxing(name_handle):

Copy link

Collaborator

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

vtune_integration.py Outdated

@@ -0,0 +1,40 @@

import ctypes

Copy link

Collaborator

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename file somehow. Probably, simlpy vtune.py

examples/vtune_integration/basic_usage_vtune_profiler.py Outdated

handle = vt.ctypes_string_handle_create(b"Head0円")

functype_task_begin = ctypes.CFUNCTYPE(None, ctypes.c_void_p, ctypes.c_void_p)

ctypes_task_begin = functype_task_begin(itt.__itt_task_begin)

Copy link

Collaborator

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be done in vtune.py, not here. And here just import these functions


 Add decorator for overloads

b0e3513

@pep8speaks

Copy link

pep8speaks commented Apr 22, 2020 •

edited

Loading

Hello @1e-to! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020年04月22日 16:23:37 UTC

etotmeni added 2 commits

April 22, 2020 19:16

pep

9660e3f


 small fix

8ddb118

AlexanderKalistratov

AlexanderKalistratov reviewed

Apr 22, 2020

View reviewed changes

sdc/datatypes/hpat_pandas_series_functions.py

@sdc_overload_method(SeriesType, 'head')

@vtune_profiling_overload(name_handle="Series_head")

Copy link

Collaborator

@AlexanderKalistratov AlexanderKalistratov Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be part of sdc_overload_method decorator. We can extract type name and method name from where.

Copy link

Collaborator

@AlexanderKalistratov AlexanderKalistratov Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually could call this decorator inside sdc_overload_method

@AlexanderKalistratov

Copy link

Collaborator

AlexanderKalistratov commented Apr 22, 2020

Great progress actually!

@kozlov-alexey kozlov-alexey added this to the gold milestone

Feb 24, 2021

PokhodenkoSA

PokhodenkoSA reviewed

Dec 6, 2021

View reviewed changes

Copy link

Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very old PR. It is better to close it.

Labels

None yet

6 participants

@1e-to @Hardcode84 @pep8speaks @AlexanderKalistratov @PokhodenkoSA @kozlov-alexey

VTune integration #814

Are you sure you want to change the base?

VTune integration #814

Uh oh!

Conversation

@1e-to 1e-to commented Apr 21, 2020

Uh oh!

Hardcode84 commented Apr 21, 2020

Uh oh!

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

@AlexanderKalistratov AlexanderKalistratov Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

pep8speaks commented Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020年04月22日 16:23:37 UTC

Uh oh!

@AlexanderKalistratov AlexanderKalistratov Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

@AlexanderKalistratov AlexanderKalistratov Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

AlexanderKalistratov commented Apr 22, 2020

Uh oh!

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pep8speaks commented Apr 22, 2020 •

edited

Loading