This repository was archived by the owner on Feb 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Support for creating pd.DataFrame from 2d numpy array #1000
Open
kozlov-alexey
wants to merge
1
commit into
IntelPython:master
from
kozlov-alexey:feature/df_ctor_from_2darray
Open
Support for creating pd.DataFrame from 2d numpy array #1000
kozlov-alexey
wants to merge
1
commit into
IntelPython:master
from
kozlov-alexey:feature/df_ctor_from_2darray
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pep8speaks
commented
Dec 19, 2021
Hello @kozlov-alexey! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
sdc/rewrites/dataframe_constructor.py:
Line 343:77: E502 the backslash is redundant between brackets
Line 357:96: E262 inline comment should start with '# '
Line 357:121: E501 line too long (130 > 120 characters)
dlee992
dlee992
reviewed
Jan 4, 2022
typingctx = resolve_dispatcher_from_str(current_target()).targetdescr.typing_context
fnty = typingctx.resolve_value_type(fix_df_index)
nb_index_type = types.none if index is None else index
fixed_index_sig = fnty.get_call_type(typingctx, (nb_index_type, nb_col_types[0]), {}) ### FIXME: need add column argument
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.