Done all tasks #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vltkachenko-ua wants to merge 8 commits into HowProgrammingWorks:master

from vltkachenko-ua:master

Open

Done all tasks #17

vltkachenko-ua wants to merge 8 commits into HowProgrammingWorks:master from vltkachenko-ua:master

Conversation

@vltkachenko-ua

Copy link

@vltkachenko-ua vltkachenko-ua commented Oct 15, 2019

No description provided.

tshemsedinov and others added 6 commits

October 14, 2019 23:48

@tshemsedinov


 Fix video

096e8ee

Closes HowProgrammingWorks#16

@tshemsedinov


 Merge branch 'master' of github.com:HowProgrammingWorks/Iteration

@tshemsedinov


 Add nested loops task

9c7edda

@tshemsedinov


 Add for..in task

d20b5b6

@tshemsedinov


 Add exercises description

bebe19a

@vltkachenko-ua


 Done all tasks

3fd6be5

tshemsedinov

tshemsedinov reviewed

Oct 15, 2019

View reviewed changes

Exercises/2-for-of.js Outdated

// to calculate sum of all given arguments

// For example sum(1, 2, 3) should return 6

letsum=0;

for(constiof args)sum+=i;

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i is not a good naming for array element, it means index in array but here is i isn't an index

Exercises/4-do-while.js Outdated

Comment on lines 10 to 11

}

while (i < args.length);

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better put it in a single line: } while (i < args.length);

Exercises/4-do-while.js Outdated

// For example sum(1, 2, 3) should return 6

if (args.length < 1) return 0;

let sum = 0;

let i = 0;

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having counter and not using pop/shift is much better for performance 👍

Exercises/6-matrix.js Outdated

for (let i = 0; i < matrix.length; i++) {

for (let j = 0; j < matrix[i].length; j++) {

//max = max < matrix[i][j] ? matrix[i][j] : max;

if (max < matrix[i][j]) max = matrix[i][j];

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expression matrix[i][j] repeated twice, and we have additional matrix[i] in line 6. See my solution to optimize code.

Exercises/6-matrix.js Outdated

// Use nested for loop to find max value in 2d matrix

// For example max([[1, 2, 3], [4, 5, 6], [7, 8, 9]])

// should return 9

let max = 0;

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can name variable as a function but it will be better to use different name.

Exercises/7-ages.js Outdated

// }

const ages = {};

for (const element in persons) {

ages[element] = persons[element]['died'] - persons[element]['born'];

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

ages[element]= persons[element]['died']-persons[element]['born'];

constperson= persons[element];

ages[element] = person.died - persons.born;

Exercises/7-ages.js Outdated

// gandhi: 79,

// hirohito: 88,

// }

const ages = {};

Copy link

Member

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use different variable name

vltkachenko-ua added 2 commits

October 16, 2019 15:44

@vltkachenko-ua


 Fixed tasks: 2, 3, 4, 6, 7

0e3260b

@vltkachenko-ua


 Fixed task 7

f432fb3

tshemsedinov

tshemsedinov approved these changes

Oct 16, 2019

View reviewed changes

Copy link

Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tshemsedinov tshemsedinov force-pushed the master branch from 2759b95 to 0d1399f Compare

November 20, 2019 23:46

Labels

None yet

2 participants

@vltkachenko-ua @tshemsedinov

Uh oh!

Done all tasks #17

Are you sure you want to change the base?

Done all tasks #17

Uh oh!

Conversation

@vltkachenko-ua vltkachenko-ua commented Oct 15, 2019

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants