Skip to content

London | 25-SDC-July | Fatma Arslantas | Sprint 1 | Hashtag link doesn't work correctly #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

AFatmaa wants to merge 1 commit into CodeYourFuture:main

from AFatmaa:fix/hashtag-punctuation

Open

London | 25-SDC-July | Fatma Arslantas | Sprint 1 | Hashtag link doesn't work correctly #67

AFatmaa wants to merge 1 commit into CodeYourFuture:main from AFatmaa:fix/hashtag-punctuation

Conversation

Copy link

@AFatmaa AFatmaa commented Dec 31, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

The old code ([^#]+) was capturing too much text. It included spaces and punctuation (like !! or .) inside the hashtag link.
I updated the regex in bloom.mjs from [^#]+ to \w+.
Now, the hashtag link correctly stops at spaces and punctuation. #SwizBiz!! works perfectly now.

Questions

I don’t have any questions, thank you!


 fix: Fix hashtags

aaa8294

@github-project-automation github-project-automation bot added this to Purple Forest Kanban

@github-project-automation github-project-automation bot moved this to Backlog in Purple Forest Kanban

@AFatmaa AFatmaa added 📅 Sprint 1 Needs Review labels

@AFatmaa AFatmaa mentioned this pull request

Bug Report: Hashtag link doesn't work correctly AFatmaa/My-Coursework-Planner#173

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review 📅 Sprint 1

1 participant