Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

London | 25-SDC-July | Fatma Arslantas | Sprint 1 | Hashtag slowing down my browser #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AFatmaa wants to merge 2 commits into CodeYourFuture:main
base: main
Choose a base branch
Loading
from AFatmaa:fix/hashtag-slows-browser

Conversation

@AFatmaa
Copy link

@AFatmaa AFatmaa commented Dec 28, 2025
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed Infinite Loop: The hashtag page was crashing because it fetched data on every single render.

  • Fix Details: In hashtag.mjs, I added a check to stop unnecessary API calls.

    • First, I normalised the hashtag input (added # if it was missing).
    • Then, I compared it with state.currentHashtag.
    • The API request now runs only if the hashtag is different from the current state.
  • Test: Added a new test (hashtag.spec.mjs) to verify that the page sends only one request.

Questions

I don’t have any questions. Thank you!

@AFatmaa AFatmaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /