Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement Missing Accessibility APIs #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecoolwinter merged 2 commits into CodeEditApp:main from thecoolwinter:missing-ax-apis
Jul 17, 2025

Conversation

@thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented Jul 17, 2025

Description

Fills out the last few missing accessibility methods for the text view.

Adds unit tests for all implemented accessibility methods.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter changed the title (削除) Missing Accessibility APIs (削除ここまで) (追記) Implement Missing Accessibility APIs (追記ここまで) Jul 17, 2025
@thecoolwinter thecoolwinter merged commit f576370 into CodeEditApp:main Jul 17, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the missing-ax-apis branch July 17, 2025 15:03
Copy link

godbout commented Aug 15, 2025

@thecoolwinter curious about when do changes made on the CodeEditTextView get merged and released in the CodeEdit app themselves. do you guys have some sort of fixed schedule, or do you do it more by feel?

Copy link
Contributor Author

We release whatever the latest version of CESE and CETV are with a CodeEdit release. We don't have a specific release schedule, but I think it will be soon considering some recent changes.

godbout reacted with thumbs up emoji

Copy link

godbout commented Aug 16, 2025

nice. thanks!

Copy link
Contributor Author

@godbout It's been released! https://github.com/CodeEditApp/CodeEdit/releases/tag/v0.3.6 let me know if it works with kindaVim or if it's still got some bugs.

Copy link

godbout commented Aug 27, 2025

@thecoolwinter thank you! will do very soon and will update you.

Copy link

godbout commented Aug 28, 2025

@thecoolwinter kV still can't make use of CodeEdit's TextView/TextArea. will review and let you know if there's anything that can be done. thanks!

Copy link

godbout commented Aug 28, 2025
edited
Loading

@thecoolwinter ok, interesting. so all the AX data needed is there. thanks for that! but somehow the CodeEditTextView doesn't refresh/update when AX data is pushed to it. i push the caret location and the selected length (through the kAXSelectedTextRangeAttribute attribute), but in the CETV the caret is just gone lol. see below:

  1. here i enter kV Normal Mode with the caret location being after the second e on line 25. what's supposed to happen is the second e gets selected (so it looks like a block cursor on e). then i press ciw which selects LeftRightSearch, deletes it, and makes kV go back to Insert Mode, which means we're not back into normal macOS. at that time LeftRightSearch is supposedly removed, and the blinking typing caret should be located after public struct . so it DOES NOT LOOK LIKE IT but behind the scene everything is happening normally lol, it's just not SHOWN in CETV. the proof is that i type this all i've described above, and everything appears where it should appear. caret at the right position, right selection was deleted, etc. it just didn't SHOW in CETV. after that i undo by going back to kV Normal Mode and pressing u to undo. we can see the changes getting undone.
Screen.Recording.2025年08月28日.at.18.41.04.mov
  1. here i use kV Visual Mode to select a few lines. you'll see the line numbers getting highlighted, but again CETV doesn't reflect the selection. then i delete with d. in that case the CETV changes get reflected. i do a bit of undo, delete again, and then use cc to delete the public enum line and switch to Insert Mode (normal macOS). then i can start typing. as with the first video, it does work. everything is at the proper place, BUT the CETV somehow doesn't refresh the changes.
Screen.Recording.2025年08月28日.at.18.41.57.mov

hope this makes sense! please lemme know if there's anything i can add to help. (if you wanna have a look at this, that is.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

AltStyle によって変換されたページ (->オリジナル) /