Fix: Prevent git popup when Source Control is disabled (#2138) #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thecoolwinter merged 1 commit into CodeEditApp:main from vksvicky:fix/issue-2138

Dec 14, 2025

Merged

Fix: Prevent git popup when Source Control is disabled (#2138) #2148

thecoolwinter merged 1 commit into CodeEditApp:main from vksvicky:fix/issue-2138

Dec 14, 2025

Conversation

@vksvicky

Copy link

Contributor

@vksvicky vksvicky commented Dec 2, 2025 •

edited

Loading

Fixed issue where CodeEdit would show "The 'git' command requires the command line developer tools. Would you like to install the tools now?" popup on every app launch, even when Source Control was completely disabled in Settings.

Description

WorkspaceView.swift was unconditionally calling git operations (refreshRemotes and refreshStashEntries) on every workspace launch
These git commands triggered macOS to show the Command Line Developer Tools installation popup if git wasn't installed
The operations ran regardless of the sourceControlIsEnabled setting

Result:

Users who disable Source Control no longer see the git tools popup
Git operations still work normally when Source Control is enabled
Popup behavior now respects user preferences as expected

Related Issues

🐞 Popup request to Install Command Line Developer Tools appear at every launch #2138

Checklist

I read and understood the contributing guide as well as the code of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code

Screenshots

@vksvicky


 Fix: Prevent git popup when Source Control is disabled ( CodeEditApp#2138

40306c6

)
Fixed issue where CodeEdit would show "The 'git' command requires the
command line developer tools. Would you like to install the tools now?"
popup on every app launch, even when Source Control was completely
disabled in Settings.
Issue Analysis:
- WorkspaceView.swift was unconditionally calling git operations
 (refreshRemotes and refreshStashEntries) on every workspace launch
- These git commands triggered macOS to show the Command Line Developer
 Tools installation popup if git wasn't installed
- The operations ran regardless of the sourceControlIsEnabled setting
Solution:
- Added guard statement to check sourceControlIsEnabled before running
 git operations in the .task block
- Now git commands only execute when Source Control is enabled in Settings
- Also updated onChange syntax to modern two-parameter form
Result:
- Users who disable Source Control no longer see the git tools popup
- Git operations still work normally when Source Control is enabled
- Popup behavior now respects user preferences as expected
Fixes CodeEditApp#2138

thecoolwinter

thecoolwinter approved these changes

Dec 14, 2025

View reviewed changes