-
Notifications
You must be signed in to change notification settings - Fork 82
Add support for placeholder-based artifacts #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #321 +/- ## ========================================== + Coverage 97.35% 97.41% +0.06% ========================================== Files 76 79 +3 Lines 17440 17743 +303 Branches 1274 1317 +43 ========================================== + Hits 16978 17285 +307 + Misses 455 447 -8 - Partials 7 11 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder-based artifacts are those which might be produced elsewhere or contain raw bitcoin script. Placeholders are used to insert the properly encoded variables at certain places in the script to produce a valid contract.
This pattern first emerged in our work for bch-xmr atomic swaps, now in another project where I had to support the EC-compatible 2 of 3 multisig contract.
Also add a sample 2 of 3 multisig contract and tests to highlight the feature and demonstrate the usage patterns.