-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Add ChaingraphNetworkProvider #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mr-zwets
commented
Jan 28, 2025
Thanks for the PR @PHCitizen 😄
One thing I noticed is that there's no extra tests for the new ChaingraphNetworkProvider
In the folder test you'll see /e2e/network, here we have tests for the network providers like FullStack.test.ts
So it would be great to have similar automated tests for the new ChaingraphNetworkProvider
Also could you change the target branch from master to next, this is were all the ongoing development happens for upcoming releases.
f403c1e to
67d7c14
Compare
Deployment failed with the following error:
The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.
rkalis
commented
Feb 4, 2025
Hey @PHCitizen thank you for creating this PR (and the other draft PR). We're currently busy with the debugging support for the advanced transaction builder and additional features for v0.11, so we will take a deeper look into your PR(s) when that is finished. You can follow that progress in #230, #257 and milestone v0.11. We expect to release that version around the May 15th upgrade or a little bit after.
mr-zwets
commented
Mar 10, 2025
One upstream issue is that my chaingraph-ts library doesn't are not filter the results by network meaning getUtxos would also return chipnet utxos
created an upstream issue for this mr-zwets/chaingraph-ts#1
closes #249