-
Notifications
You must be signed in to change notification settings - Fork 505
Fact Decorator Rough Sketch #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would introduce the concept of a FactDecorator to match the idea of a operator decorator. Fact Decorators could be used to do things like getting keysOf, valuesOf, or sizeOf facts. Additionally in order to Remove JSONPathPlus as such a dependency we could use the fact decorator pattern, even if we wanted to ship our own decorator that depended on JSON path we could move it to a peer dependency.
Owner
CacheControl
commented
Oct 17, 2024
@chris-pardy the approach makes sense to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CacheControl this is very much just a rough sketch of what a "FactDecorator" that matched the "Operator Decorator" would look like.
The idea here is to add support for a way to declaratively manipulate fact values without needed to manually add new facts.
I've created defaults for what I think the most common use cases are:
keyOf/valueOf- these work on the methods defined on Map but also use the Object.keys / Object.values methods to enumerate the keys and values of other objects. For instance you could now do:I've also added
sizeOfwhich works on strings so:Finally I wanted to showcase how we could use this to potentially move the handling of JSON Path properties out of the Almanac and into something that would let us move the JSONPathPlus dependency to a peer-dependency which would make it much easier to tackle breaking changes.