-
Notifications
You must be signed in to change notification settings - Fork 41
Respect CMAKE_EXE_LINKER_FLAGS/CMAKE_SHARED_LINKER_FLAGS flags set via CLI #830
Conversation
...a CLI In case of Clang, we were always overriding the above mentioned flags and hence cmake args were ignored (resuliting in link errors)
010d8c6 to
6f9c31e
Compare
bbpbuildbot
commented
Jun 22, 2022
Logfiles from GitLab pipeline #61703 (:white_check_mark:) have been uploaded here!
Status and direct links:
- ✅ spack_setup
- ✅ build:nmodl
- ✅ build:coreneuron:mod2c:nvhpc:acc
- ✅ build:coreneuron:mod2c:nvhpc:acc:unified
- ✅ build:coreneuron:nmodl:nvhpc:omp
- ✅ build:coreneuron:nmodl:nvhpc:acc
- ✅ build:coreneuron:mod2c:intel
- ✅ build:coreneuron:nmodl:intel
- ✅ build:neuron:mod2c:nvhpc:acc
- ✅ build:neuron:nmodl:nvhpc:omp
- ✅ build:neuron:nmodl:nvhpc:acc
- ✅ build:neuron:mod2c:intel
- ✅ build:neuron:nmodl:intel
- ✅ test:coreneuron:mod2c:nvhpc:acc
- ✅ test:coreneuron:mod2c:nvhpc:acc:unified
- ✅ test:coreneuron:nmodl:nvhpc:omp
- ✅ test:coreneuron:nmodl:nvhpc:acc
- ✅ test:coreneuron:mod2c:intel
- ✅ test:coreneuron:nmodl:intel
- ✅ test:neuron:mod2c:nvhpc:acc
- ✅ test:neuron:nmodl:nvhpc:omp
- ✅ test:neuron:nmodl:nvhpc:acc
- ✅ test:neuron:mod2c:intel
- ✅ test:neuron:nmodl:intel
bbpbuildbot
commented
Jun 22, 2022
Logfiles from GitLab pipeline #61704 (:white_check_mark:) have been uploaded here!
Status and direct links:
- ✅ spack_setup
- ✅ build:nmodl
- ✅ build:coreneuron:mod2c:nvhpc:acc
- ✅ build:coreneuron:mod2c:nvhpc:acc:unified
- ✅ build:coreneuron:nmodl:nvhpc:omp
- ✅ build:coreneuron:nmodl:nvhpc:acc
- ✅ build:coreneuron:mod2c:intel
- ✅ build:coreneuron:nmodl:intel
- ✅ build:neuron:mod2c:nvhpc:acc
- ✅ build:neuron:nmodl:nvhpc:omp
- ✅ build:neuron:nmodl:nvhpc:acc
- ✅ build:neuron:mod2c:intel
- ✅ build:neuron:nmodl:intel
- ✅ test:coreneuron:mod2c:nvhpc:acc
- ✅ test:coreneuron:mod2c:nvhpc:acc:unified
- ✅ test:coreneuron:nmodl:nvhpc:omp
- ✅ test:coreneuron:nmodl:nvhpc:acc
- ✅ test:coreneuron:mod2c:intel
- ✅ test:coreneuron:nmodl:intel
- ✅ test:neuron:mod2c:nvhpc:acc
- ✅ test:neuron:nmodl:nvhpc:omp
- ✅ test:neuron:nmodl:nvhpc:acc
- ✅ test:neuron:mod2c:intel
- ✅ test:neuron:nmodl:intel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use https://cmake.org/cmake/help/latest/command/string.html#append to avoid repeating the variable name, I think, but no big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see the changes to this file just re-order some flags. Is that important?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now see the commit message about it needing to be later. Can you add a comment/documentation about that issue/detail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I should have put this PR in draft - haven't thoroughly checked how/why -Wl,--as-needed causes this but I remember this flag was needed in case wheel building. I will check this bit later and get back here.
Description
In the case of Clang, we were always overriding the above-mentioned flags
and hence cmake args were ignored (resulting in link errors)
How to test this?
On BB5 with Clang compiler
Test System
BB5