Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Fixes and improvements from LLVM/XLC work. #716

Merged
olupton merged 3 commits into hackathon_main from olupton/generic-xlc-clang-fixes
Dec 14, 2021

Conversation

@olupton
Copy link
Contributor

@olupton olupton commented Dec 13, 2021

Description
This is basically the part of #706 that is not hacking the build system to try and build for GPU with XLC or LLVM.

Goes with BlueBrain/nmodl#782.

Use certain branches for the SimulationStack CI

CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=olupton/llvm-gpu

Copy link
Collaborator

Copy link
Collaborator

@olupton olupton merged commit 781d34f into hackathon_main Dec 14, 2021
@olupton olupton deleted the olupton/generic-xlc-clang-fixes branch December 14, 2021 09:31
olupton added a commit that referenced this pull request Dec 23, 2021
Summary of changes:
 - Support OpenMP target offload when NMODL and GPU support are enabled.
 (#693, #704, #705, #707, #708, #716, #719)
 - Use sensible defaults for the --nwarp parameter, improving the performance
 of the Hines solver with --cell-permute=2 on GPU. (#700, #710, #718)
 - Use a Boost memory pool, if Boost is available, to reduce the number of
 independent CUDA unified memory allocations used for Random123 stream
 objects. This speeds up initialisation of models using Random123, and also
 makes it feasible to use NSight Compute on models using Random123 and for
 NSight Systems to profile initialisation. (#702, #703)
 - Use -cuda when compiling with NVHPC and OpenACC or OpenMP, as recommended
 on the NVIDIA forums. (#721)
 - Do not compile for compute capability 6.0 by default, as this is not
 supported by NVHPC with OpenMP target offload.
 - Add new GitLab CI tests so we test CoreNEURON + NMODL with both OpenACC and
 OpenMP. (#698, #717)
 - Add CUDA runtime header search path explicitly, so we don't rely on it being
 implicit in our NVHPC localrc.
 - Cleanup unused code. (#711)
Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com>
Co-authored-by: Christos Kotsalos <christos.kotsalos@epfl.ch>
Co-authored-by: Nicolas Cornu <nicolas.cornu@epfl.ch>
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Summary of changes:
 - Support OpenMP target offload when NMODL and GPU support are enabled.
 (BlueBrain/CoreNeuron#693, BlueBrain/CoreNeuron#704, BlueBrain/CoreNeuron#705, BlueBrain/CoreNeuron#707, BlueBrain/CoreNeuron#708, BlueBrain/CoreNeuron#716, BlueBrain/CoreNeuron#719)
 - Use sensible defaults for the --nwarp parameter, improving the performance
 of the Hines solver with --cell-permute=2 on GPU. (BlueBrain/CoreNeuron#700, BlueBrain/CoreNeuron#710, BlueBrain/CoreNeuron#718)
 - Use a Boost memory pool, if Boost is available, to reduce the number of
 independent CUDA unified memory allocations used for Random123 stream
 objects. This speeds up initialisation of models using Random123, and also
 makes it feasible to use NSight Compute on models using Random123 and for
 NSight Systems to profile initialisation. (BlueBrain/CoreNeuron#702, BlueBrain/CoreNeuron#703)
 - Use -cuda when compiling with NVHPC and OpenACC or OpenMP, as recommended
 on the NVIDIA forums. (BlueBrain/CoreNeuron#721)
 - Do not compile for compute capability 6.0 by default, as this is not
 supported by NVHPC with OpenMP target offload.
 - Add new GitLab CI tests so we test CoreNEURON + NMODL with both OpenACC and
 OpenMP. (BlueBrain/CoreNeuron#698, BlueBrain/CoreNeuron#717)
 - Add CUDA runtime header search path explicitly, so we don't rely on it being
 implicit in our NVHPC localrc.
 - Cleanup unused code. (BlueBrain/CoreNeuron#711)
Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com>
Co-authored-by: Christos Kotsalos <christos.kotsalos@epfl.ch>
Co-authored-by: Nicolas Cornu <nicolas.cornu@epfl.ch>
CoreNEURON Repo SHA: BlueBrain/CoreNeuron@423ae6c 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iomaganaris iomaganaris Awaiting requested review from iomaganaris

1 more reviewer

@alkino alkino alkino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /