Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Give possibility to change mpiexec configuration for integration tests #699

Draft
alkino wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from use_test_exec_prefix

Conversation

@alkino
Copy link
Member

@alkino alkino commented Nov 29, 2021

Some mpiexec version does not have the option -n, so it should be configurable

Copy link
Collaborator

pramodk commented Dec 20, 2021

@alkino : could you check failing CI?

Copy link

Codecov Report

Merging #699 (93a6567) into master (7b0b6d9) will decrease coverage by 2.02%.
The diff coverage is n/a.

❗ Current head 93a6567 differs from pull request most recent head 7295f4a. Consider uploading reports for the commit 7295f4a to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 55.51% 53.49% -2.03% 
==========================================
 Files 107 107 
 Lines 8947 8947 
==========================================
- Hits 4967 4786 -181 
- Misses 3980 4161 +181 
Impacted Files Coverage Δ
coreneuron/network/multisend_setup.cpp 44.48% <0.00%> (-30.52%) ⬇️
coreneuron/network/multisend.cpp 42.50% <0.00%> (-19.00%) ⬇️
coreneuron/mpi/lib/mpispike.cpp 58.82% <0.00%> (-5.89%) ⬇️
coreneuron/utils/progressbar/progressbar.cpp 82.95% <0.00%> (-5.69%) ⬇️
coreneuron/io/nrn_setup.cpp 82.15% <0.00%> (-3.54%) ⬇️
coreneuron/network/netcon.hpp 51.61% <0.00%> (-3.23%) ⬇️
coreneuron/network/netcvode.cpp 71.24% <0.00%> (-2.88%) ⬇️
coreneuron/network/partrans.cpp 93.02% <0.00%> (-2.33%) ⬇️
coreneuron/io/output_spikes.cpp 87.50% <0.00%> (-1.48%) ⬇️
coreneuron/sim/fadvance_core.cpp 82.82% <0.00%> (-0.62%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0b6d9...7295f4a. Read the comment docs.

Copy link
Collaborator

pramodk commented Mar 2, 2022

@alkino : converting this to draft until CI is fixed. If you think this is not relevant now, feel free to close this.

@pramodk pramodk marked this pull request as draft March 2, 2022 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /