WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs

To: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: 2008年12月17日 16:43:38 +0000
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxx
Delivery-date: 2008年12月17日 09:15:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081217115217G.fujita.tomonori@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1229458644@xxxxxxxxxxxxxxxxx> <aba0c734944520d4b892.1229458648@xxxxxxxxxxxxxxxxx> <20081217113804F.fujita.tomonori@xxxxxxxxxxxxx> <20081217115217G.fujita.tomonori@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2008年12月17日 at 11:51 +0900, FUJITA Tomonori wrote:
> On 2008年12月17日 11:48:41 +0900
> FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:
>
> > On 2008年12月16日 12:17:28 -0800
> > Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> > 
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > ---
> > > lib/swiotlb.c | 10 +++-------
> > > 1 file changed, 3 insertions(+), 7 deletions(-)
> > 
> > This patch is wrong.
> > 
> > dma_mask and coherent_dma_mask represent different restrictions.
> > 
> > You can't use coherent_dma_mask for alloc_coherent.
>
> Oops, "you can't use dma_mask for alloc_coherent."
You are right, I completely overlooked that it was coherent_dma_mask in
one place and just dma_mask in the other, sorry for the noise.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere , Jeremy Fitzhardinge
Next by Date: Re: [Xen-devel] pv_ops dom0 x86_32 PAE kernel buildlog of missingsymbols... , Ian Campbell
Previous by Thread: [Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere , Jeremy Fitzhardinge
Next by Thread: [Xen-devel] [PATCH 05 of 14] swiotlb: add comment where we handle the overflow of a dma mask on 32 bit , Jeremy Fitzhardinge
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /