WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH 04 of 14] swiotlb: consistently use address_needs_map

To: Ingo Molnar <mingo@xxxxxxx>
Subject: [Xen-devel] [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: 2008年12月16日 12:17:28 -0800
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Delivery-date: 2008年12月16日 12:21:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1229458644@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 lib/swiotlb.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -465,13 +465,9 @@
 dma_addr_t dev_addr;
 void *ret;
 int order = get_order(size);
- u64 dma_mask = DMA_32BIT_MASK;
-
- if (hwdev && hwdev->coherent_dma_mask)
- dma_mask = hwdev->coherent_dma_mask;
 
 ret = (void *)__get_free_pages(flags, order);
- if (ret && !is_buffer_dma_capable(dma_mask, virt_to_bus(ret), size)) {
+ if (ret && !address_needs_mapping(hwdev, virt_to_bus(ret), size)) {
 /*
 * The allocated memory isn't reachable by the device.
 * Fall back on swiotlb_map_single().
@@ -495,9 +491,9 @@
 dev_addr = virt_to_bus(ret);
 
 /* Confirm address can be DMA'd by device */
- if (!is_buffer_dma_capable(dma_mask, dev_addr, size)) {
+ if (!address_needs_mapping(hwdev, dev_addr, size)) {
 printk("hwdev DMA mask = 0x%016Lx, dev_addr = 0x%016Lx\n",
- (unsigned long long)dma_mask,
+ (unsigned long long)dma_get_mask(hwdev),
 (unsigned long long)dev_addr);
 
 /* DMA_TO_DEVICE to avoid memcpy in unmap_single */
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] [PATCH 03 of 14] swiotlb: move some definitions to header , Jeremy Fitzhardinge
Next by Date: [Xen-devel] [PATCH 05 of 14] swiotlb: add comment where we handle the overflow of a dma mask on 32 bit , Jeremy Fitzhardinge
Previous by Thread: [Xen-devel] [PATCH 03 of 14] swiotlb: move some definitions to header , Jeremy Fitzhardinge
Next by Thread: [Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere , Jeremy Fitzhardinge
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /