xen-devel
[Xen-devel] Re: [RFC PATCH 15/33] move segment checks to subarch
|
To: |
Arjan van de Ven <arjan@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 15/33] move segment checks to subarch |
|
From: |
Zachary Amsden <zach@xxxxxxxxxx> |
|
Date: |
2006年7月18日 04:28:01 -0700 |
|
Cc: |
Andrew Morton <akpm@xxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> |
|
Delivery-date: |
2006年7月18日 04:28:26 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1153217344.3038.31.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20060718091807.467468000@xxxxxxxxxxxx> <20060718091952.263186000@xxxxxxxxxxxx> <1153217344.3038.31.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 1.5.0.4 (X11/20060516) |
Arjan van de Ven wrote:
On Tue, 2006年07月18日 at 00:00 -0700, Chris Wright wrote:
plain text document attachment (i386-segments)
We allow for the fact that the guest kernel may not run in ring 0.
This requires some abstraction in a few places when setting %cs or
checking privilege level (user vs kernel).
- regs.xcs = __KERNEL_CS;
+ regs.xcs = get_kernel_cs();
Hi,
wouldn't this patch be simpler if __KERNEL_CS just became the macro that
currently is get_kernel_cs() for the XEN case? then code like this
doesn't need changing at all...
The tradeoff is that then you can't use __KERNEL_CS is assembler code,
and it is used in entry.S to detect NMI / debug trap workarounds - which
don't actually need to be paravirtualized, as it is easier to hide the
nasty cases which cause those side effects.
Zach
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|