| To: | "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain) |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 4 Jul 2006 08:06:57 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2006年7月04日 00:13:56 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20060704.143731.74693697.kuwa@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20060704.143731.74693697.kuwa@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 4 Jul 2006, at 06:37, KUWAMURA Shin'ya wrote:
Where does the magic number '31' come from in the first place? That's not the number Xen uses. It could conflict with the domain id of a non-idle domain.This patch removes the magic number "31" for readability. The number "31" means the idle domain ID. In detail: - display the idle domain ID with "Idle" instead of "31" - write to the file "log-idle.log" instead of "log-dom31.log". Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
-- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] VT is comically slow , Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel][Patch] Fix the kernel build failure issue on HVM SMP guests which use 2M pages , Xin, Xiaohui |
| Previous by Thread: | [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain) , KUWAMURA Shin'ya |
| Next by Thread: | Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain) , KUWAMURA Shin'ya |
| Indexes: | [Date] [Thread] [Top] [All Lists] |