WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)
From: "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Date: 2006年7月04日 14:37:31 +0900 (JST)
Delivery-date: 2006年7月03日 22:39:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,
This patch removes the magic number "31" for readability. The number
"31" means the idle domain ID.
In detail:
- display the idle domain ID with "Idle" instead of "31" 
- write to the file "log-idle.log" instead of "log-dom31.log".
Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>
Thanks,
-- 
 KUWAMURA Shin'ya
diff -r fd6d12935b56 tools/xenmon/xenmon.py
--- a/tools/xenmon/xenmon.py Mon Jul 3 16:07:20 2006 +0100
+++ b/tools/xenmon/xenmon.py Tue Jul 4 13:05:21 2006 +0900
@@ -36,6 +36,7 @@ import sys
 # constants
 NSAMPLES = 100
 NDOMAINS = 32
+IDLE_DOMAIN = 31 # idle domain's ID
 
 # the struct strings for qos_info
 ST_DOM_INFO = "6Q4i32s"
@@ -253,6 +254,14 @@ def display(scr, row, col, str, attr=0):
 sys.exit(1)
 
 
+# diplay domain id
+def display_domain_id(scr, row, col, dom):
+ if dom == IDLE_DOMAIN:
+ display(scr, row, col-1, "Idle")
+ else:
+ display(scr, row, col, "%d" % dom)
+
+
 # the live monitoring code
 def show_livestats(cpu):
 ncpu = 1 # number of cpu's on this platform
@@ -361,7 +370,7 @@ def show_livestats(cpu):
 # display gotten
 row += 1 
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 col += 4
 display(stdscr, row, col, "%s" % time_scale(h2[dom][0][0]))
 col += 12
@@ -386,7 +395,7 @@ def show_livestats(cpu):
 if options.allocated:
 row += 1
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 col += 28
 display(stdscr, row, col, "%s/ex" % time_scale(h2[dom][1]))
 col += 42
@@ -398,7 +407,7 @@ def show_livestats(cpu):
 if options.blocked:
 row += 1
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 col += 4
 display(stdscr, row, col, "%s" % time_scale(h2[dom][2][0]))
 col += 12
@@ -418,7 +427,7 @@ def show_livestats(cpu):
 if options.waited:
 row += 1
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 col += 4
 display(stdscr, row, col, "%s" % time_scale(h2[dom][3][0]))
 col += 12
@@ -438,7 +447,7 @@ def show_livestats(cpu):
 if options.excount:
 row += 1
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 
 col += 28
 display(stdscr, row, col, "%d/s" % h2[dom][4])
@@ -451,7 +460,7 @@ def show_livestats(cpu):
 if options.iocount:
 row += 1
 col = 2
- display(stdscr, row, col, "%d" % dom)
+ display_domain_id(stdscr, row, col, dom)
 col += 4
 display(stdscr, row, col, "%d/s" % h2[dom][5][0])
 col += 24
@@ -558,7 +567,10 @@ def writelog():
 curr = last = time.time()
 outfiles = {}
 for dom in range(0, NDOMAINS):
- outfiles[dom] = Delayed("%s-dom%d.log" % (options.prefix, dom), 'w')
+ if dom == IDLE_DOMAIN:
+ outfiles[dom] = Delayed("%s-idle.log" % options.prefix, 'w')
+ else:
+ outfiles[dom] = Delayed("%s-dom%d.log" % (options.prefix, dom), 
'w')
 outfiles[dom].delayed_write("# passed cpu dom cpu(tot) cpu(%) cpu/ex 
allocated/ex blocked(tot) blocked(%) blocked/io waited(tot) waited(%) waited/ex 
ex/s io(tot) io/ex\n")
 
 while options.duration == 0 or interval < (options.duration * 1000):
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] [PATCH] libxenstore should be executable , Jeremy Katz
Next by Date: Re: [Xen-devel] [PATCH] libxenstore should be executable , Bastian Blank
Previous by Thread: [Xen-devel] [PATCH] libxenstore should be executable , Jeremy Katz
Next by Thread: Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain) , Keir Fraser
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /