WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] Re: PATCH: was Re**2: PATCH (and RFC): new dom0 hypercall: D

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Subject: [Xen-devel] Re: PATCH: was Re**2: PATCH (and RFC): new dom0 hypercall: DOM0_DOMAIN_SETUP
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: 2006年6月19日 16:32:31 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Alex Williamson <alex.williamson@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: 2006年6月19日 08:32:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200606191720.32894.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200606151019.24560.Tristan.Gingold@xxxxxxxx> <200606191643.55983.Tristan.Gingold@xxxxxxxx> <2d74eb264c8407068db519e0e10c0d5e@xxxxxxxxxxxx> <200606191720.32894.Tristan.Gingold@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 19 Jun 2006, at 16:20, Tristan Gingold wrote:
How does that ease binary compatibility if you want to add extra common
fields later? You mean to have a pointer to the arch-dep struct?
Err, this was a bad argument. I was thinking about avoiding #if arch /#endif
in this public header.
I'm not too concerned about a few ifdefs here and there in the header files. I think sometimes it's easier just to have all the architectural cases in one place rather than having to go to separate arch-specific header files, even if it is "inelegant".
PS. The flag name: DOM0_DOMAIN_SETUP_ would actually be a fine prefix
for flags. Use whatever you prefer.
Here is the patch. I hope it looks like you expect it :-)
Looks fine.
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] PATCH: was Re**2: PATCH (and RFC): new dom0 hypercall: DOM0_DOMAIN_SETUP , Tristan Gingold
Next by Date: [Xen-devel] VMX status report 10426:840f33e54054 , Zheng, Jeff
Previous by Thread: [Xen-devel] PATCH: was Re**2: PATCH (and RFC): new dom0 hypercall: DOM0_DOMAIN_SETUP , Tristan Gingold
Next by Thread: [Xen-devel] xenbus api , Fabien Hermenier
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /