WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag)

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag)
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: 2006年12月22日 09:51:41 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: 2006年12月22日 01:50:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1B15874.628F%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <458BB3E5.76E4.0078.0@xxxxxxxxxx> <C1B15874.628F%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
If this was with -Wconst-qual, yes. But didn't we agree that at least for now 
we'll
not add that warning (and hence we also don't absolutely have to change code
only affected by it)? Jan
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 22.12.06 10:40 >>>
Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast
hidden inside the ADDR macro is dropping the const qualifier.
 -- Keir
On 22/12/06 9:31 am, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> I object to the change to variable_test_bit() - why is that needed? I had
> specifically
> submitted a patch to get the const qualifier added there. Jan
>
>>>> "Christoph Egger" <Christoph.Egger@xxxxxxx> 22.12.06 10:05 >>>
>
> Hi!
>
> I catched two pieces with debug and crash_debug enabled.
> One of them fixes a build error even without the -Wcast-qual flag.
>
> Patch attached.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] Problem of netfront by network-attach/detach , Kasai Takanori
Next by Date: Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag) , Christoph Egger
Previous by Thread: Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag) , Keir Fraser
Next by Thread: Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag) , Christoph Egger
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /