Issue 504: Patch to short circuit an exact match

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(329)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 504: Patch to short circuit an exact match (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 8 months ago by GvR

Modified:
16 years, 5 months ago

Reviewers:
python

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

http://bugs.python.org/issue2303

Patch Set 1 #

Downloaded from: http://bugs.python.org/file9742/isinst.diff

Created: 17 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
Objects/abstract.c	View	1 chunk	+5 lines, -1 line	1 comment	Download

Total messages: 1

GvR

http://codereview.appspot.com/504/diff/1/21 File Objects/abstract.c (right): http://codereview.appspot.com/504/diff/1/21#newcode2914 Line 2914: if (Py_TYPE(inst) == cls && !PyTuple_Check(cls)) The tuple ...

17 years, 8 months ago (2008年05月02日 05:20:44 UTC) #1

http://codereview.appspot.com/504/diff/1/21
File Objects/abstract.c (right):
http://codereview.appspot.com/504/diff/1/21#newcode2914
Line 2914: if (Py_TYPE(inst) == cls && !PyTuple_Check(cls))
The tuple check is technically redundant. :-)