#10109 closed (fixed)
Move raw sql from models.fields.related to models.sql.query
Reported by: | David Larlet | Owned by: | Alex Gaynor |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.0 |
Severity: | Keywords: | ||
Cc: | artagnon, Jannis Leidel, Sergey Belov | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Otherwise backends which do not rely on sql can't use many-to-many relations as discussed here:
http://groups.google.com/group/django-developers/browse_thread/thread/c3cd2eb4f63aed5d/6e8de9e05424d18f
(do not care with messages from people that doesn't know how to use reply-to on mailing-lists)
Now let's discuss around the proposed patch.
Attachments (5)
- patch_django_10109.20090123.diff (14.3 KB ) - added by David Larlet 17 years ago.
- Initial patch, without any documentation nor tests, design discussion for now
- patch_django_10109.20090422.diff (14.7 KB ) - added by David Larlet 16 years ago.
- Update patch against r10618
- m2m-refactor.r11683.diff (58.8 KB ) - added by Russell Keith-Magee 16 years ago.
- RC1 of the m2m refactor stemming from Alex's GSoC 2009 project
- m2m-refactor.r11683.2.diff (61.6 KB ) - added by Russell Keith-Magee 16 years ago.
- RC2 of m2m-refactor patch. Incorporates fix for abstract base classes.
- m2m-refactor.r11705.diff (61.7 KB ) - added by Russell Keith-Magee 16 years ago.
- RC3 for m2m-refactor patch. Incorporates unique_together fix.
Download all attachments as: .zip
Change History (18)
by David Larlet, 17 years ago
Attachment: | patch_django_10109.20090123.diff added |
---|
Initial patch, without any documentation nor tests, design discussion for now
comment:1 by David Larlet, 17 years ago
Needs documentation: | set |
---|---|
Needs tests: | set |
comment:2 by Jacob, 17 years ago
Triage Stage: | Unreviewed → Accepted |
---|
This needs to happen as part of a bigger refactor of related fields.
comment:3 by artagnon, 17 years ago
Cc: | artagnon added |
---|
comment:4 by Alex Gaynor, 16 years ago
Noting here that this(or some variant thereof) is going to be a blocker on having many to many fields work correctly with Multiple Database support(GSOC).
by David Larlet, 16 years ago
Attachment: | patch_django_10109.20090422.diff added |
---|
Update patch against r10618
comment:5 by David Larlet, 16 years ago
Owner: | changed from David Larlet to Alex Gaynor |
---|
For the record:
[15:43] <Alex_Gaynor> david`bgk: bitchin! There's probably no time for that to go in before 1.1. But if you remind me I'll bug the shit out of jacobkm and russ to get it in fterwords
I'll ping you anyway.
comment:6 by Russell Keith-Magee, 16 years ago
See #11795 for a related request that this ticket may make possible.
comment:7 by Jannis Leidel, 16 years ago
Cc: | Jannis Leidel added |
---|
comment:8 by Sergey Belov, 16 years ago
Cc: | Sergey Belov added |
---|
by Russell Keith-Magee, 16 years ago
Attachment: | m2m-refactor.r11683.diff added |
---|
RC1 of the m2m refactor stemming from Alex's GSoC 2009 project
comment:9 by Russell Keith-Magee, 16 years ago
The patch I have just uploaded is ready for trunk. The code is also available on Alex Gaynor's github branch
My intention is to commit this mid next week. Feedback is welcome.
comment:10 by Russell Keith-Magee, 16 years ago
milestone: | → 1.2 |
---|---|
Needs documentation: | unset |
Needs tests: | unset |
by Russell Keith-Magee, 16 years ago
Attachment: | m2m-refactor.r11683.2.diff added |
---|
RC2 of m2m-refactor patch. Incorporates fix for abstract base classes.
comment:11 by Johannes Dollinger, 16 years ago
Another small issue: Intermediary models should have 'unique_together': (from_, to),
to match the old behaviour.
by Russell Keith-Magee, 16 years ago
Attachment: | m2m-refactor.r11705.diff added |
---|
RC3 for m2m-refactor patch. Incorporates unique_together fix.
comment:12 by Russell Keith-Magee, 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |