homepage

'make test' runs all the network tests.
Some of the tests in test_ssl fail instead of skip if svn.python.org is not accessible.
$ ./python -m test -v -u all test_ssl
======================================================================
ERROR: test_non_blocking_connect_ex (test.test_ssl.NetworkedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "/home/vinson/workspace/cpython-master/Lib/test/test_ssl.py", line 1404, in test_non_blocking_connect_ex
 s.do_handshake()
 File "Lib/ssl.py", line 978, in do_handshake
 self._check_connected()
 File "Lib/ssl.py", line 776, in _check_connected
 self.getpeername()
OSError: [Errno 107] Transport endpoint is not connected
======================================================================
FAIL: test_connect_ex (test.test_ssl.NetworkedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "Lib/test/test_ssl.py", line 1381, in test_connect_ex
 self.assertEqual(0, s.connect_ex(("svn.python.org", 443)))
AssertionError: 0 != 111
======================================================================
FAIL: test_timeout_connect_ex (test.test_ssl.NetworkedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "Lib/test/test_ssl.py", line 1428, in test_timeout_connect_ex
 self.assertIn(rc, (errno.EAGAIN, errno.EWOULDBLOCK))
AssertionError: 111 not found in (11, 11)
----------------------------------------------------------------------
Ran 117 tests in 3.123s
FAILED (failures=2, errors=1, skipped=20)
test test_ssl failed
1 test failed:
 test_ssl

The attached patch should fix the test failures.

I tested the attached patch on latest cpython master and it works for me.
test_ciphers (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_connect (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_connect_cadata (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_connect_capath (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_connect_ex (test.test_ssl.NetworkedTests) ... skipped 'svn.python.org cannot be reached: Connection refused'
test_connect_with_context (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_context_setget (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_get_ca_certs_capath (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_get_server_certificate (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_makefile_close (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_non_blocking_connect_ex (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_non_blocking_handshake (test.test_ssl.NetworkedTests) ... skipped "Resource 'svn.python.org' is not available"
test_timeout_connect_ex (test.test_ssl.NetworkedTests) ... skipped 'svn.python.org cannot be reached: Connection refused'
test_handshake (test.test_ssl.NetworkedBIOTests) ... skipped "Resource 'svn.python.org' is not available"
test_read_write_data (test.test_ssl.NetworkedBIOTests) ... skipped "Resource 'svn.python.org' is not available"
Tested-by: Vinson Lee <vlee@twitter.com>

The two changes to test_ssl.py look okay to me, although they will need updating since the Issue 24841 changeover to pythontest.net.
But I don’t think it is a good idea to add ENOTCONN to the list of errors ignored by all transient_internet() tests. In most cases, ENOTCONN suggests a programming error, not a network problem. I think a better solution would be to call connect_ex() again in test_non_blocking_connect_ex(), and retrieve the result (probably also ECONNREFUSED like the other failures, or 0 if successful).

> although they will need updating since the Issue 24841 changeover to pythontest.net.
I think you meant issue 25940, right? :)
Do you want me to wait for issue 25940?

Yes sorry I did mean Issue 25940 (too many bug numbers!), but only the main change which has already been made (revision adf750b1252d etc). So you don’t have to wait for that.

test_ssl doesn't use svn.python.org anymore and it now better handle network failures. I close the issue as out of date.