This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年07月08日 14:19 by Saimadhav.Heblikar, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_percolator-34.diff | Saimadhav.Heblikar, 2014年07月08日 14:19 | review | ||
| test_percolator-34-v2.diff | Saimadhav.Heblikar, 2014年07月17日 07:00 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg222561 - (view) | Author: Saimadhav Heblikar (Saimadhav.Heblikar) * | Date: 2014年07月08日 14:19 | |
Attached is a unittest for idlelib.Percolator. 2.7 version will be added once this is OK. |
|||
| msg222730 - (view) | Author: Tal Einat (taleinat) * (Python committer) | Date: 2014年07月11日 09:08 | |
I've reviewed the patch and made my remarks in the review tool. These tests don't test the central functionality of Percolator nearly enough. We should test, at least: 1) That the text actually went through the filter (and not directly to the Text widget). 2) That if a filter modifies the text, the modified text appears in the Text widget. 3) That a filter can stop the event from continuing through the following filters. 4) That having more than one filter modify the arguments works. 5) That not having any filters works. 6) That this doesn't only work on a Text widget's "insert" and "delete" events. There are probably more things we should test. Take a look at what this is used for in practice in the code for ideas. |
|||
| msg265800 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年05月18日 02:48 | |
New changeset eebccf05903e by Terry Jan Reedy in branch '3.5': Issue #21939: Test IDLE percolator. Original patch by Saimadhav Heblikar. https://hg.python.org/cpython/rev/eebccf05903e |
|||
| msg265801 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2016年05月18日 02:54 | |
Tal, thanks for the suggestions. Saimadhav added tests for at least some of them. Part of the difficulty in adding IDLE tests is that it is too easy to write tests to the code instead of the use of the code. This is especially true when side-effects (changing a widget) are the main intended effect. I plan to work more on the latter. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:05 | admin | set | github: 66138 |
| 2016年05月18日 02:54:50 | terry.reedy | set | status: open -> closed assignee: terry.reedy versions: + Python 3.6, - Python 2.7, Python 3.4 messages: + msg265801 type: enhancement resolution: fixed stage: resolved |
| 2016年05月18日 02:48:54 | python-dev | set | nosy:
+ python-dev messages: + msg265800 |
| 2014年07月17日 07:00:27 | Saimadhav.Heblikar | set | files: + test_percolator-34-v2.diff |
| 2014年07月11日 09:08:23 | taleinat | set | messages: + msg222730 |
| 2014年07月08日 14:19:46 | Saimadhav.Heblikar | create | |